Fix rust-call ICE in mir-inliner #98823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rust-highfive
added
the
S-waiting-on-review
cjgillot
reviewed
Jul 3, 2022
| @@ -180,16 +180,20 @@ impl<'tcx> Inliner<'tcx> { | |||
| return Err("failed to normalize return type"); | |||
| } | |||
| if callsite.fn_sig.abi() == Abi::RustCall { | |||
| let mut args = args.into_iter(); | |||
| let _ = args.next(); // Skip `self` argument. | |||
| let arg_tuple_ty = args.next().unwrap().ty(&caller_body.local_decls, self.tcx); | |||
There was a problem hiding this comment.
We should contemplate banning the use of unwrap from the compiler 😄.
|
Thanks @compiler-errors |
|
📌 Commit 3406319 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 3, 2022
…e, r=cjgillot Fix rust-call ICE in mir-inliner Fixes rust-lang#98821 r? `@cjgillot`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 4, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#98501 (rustc_passes/src/entry.rs: De-duplicate more code with `fn throw_attr_err()`) - rust-lang#98774 (rustdoc: make source sidebar toggle a real button) - rust-lang#98806 (Fix long declaration trailing whitespace) - rust-lang#98823 (Fix rust-call ICE in mir-inliner) - rust-lang#98870 (Add regression test for rust-lang#86784) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98821
r? @cjgillot